Skip to content

bootstrap: Inhibit download-rustc in CI when tools are changed #140322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bootstrap: Inhibit download-rustc in CI when tools are changed #140322

wants to merge 2 commits into from

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Apr 26, 2025 •
edited
Loading

This automatically avoids situations like #139998 (comment) and #140177 (comment), where a sensitive change to compiletest was eligible for download-rustc, preventing the collection of proper test metrics for comparison.

While the primary goal is to make compiletest changes inhibit download-rustc, this PR ends up making any change to src/tools inhibit download-rustc (but only in CI builds). With the current code, it's not clear how to “un-exempt” individual subdirectories that are covered by another exemption.

See https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20tool.20changes.20inhibit.20download-rustc.20on.20CI.3F for associated discussion.

@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 26, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zalathar Zalathar force-pushed the download-rustc-tools branch from 9f355a3 to b05be37 Compare April 26, 2025 05:13
@jieyouxu
Copy link
Member

r? @onur-ozkan (discussion in #t-infra/bootstrap > Should tool changes inhibit download-rustc on CI?)

@rustbot rustbot assigned onur-ozkan and unassigned albertlarsan68 Apr 28, 2025
@onur-ozkan
Copy link
Member

Like I said on the Zulip thread, I think the proper solution would be to investigate and fix the issue of "some tests being ignored" rather than excluding tool paths from ci-rustc. Those tools don't have any effect on the rustc builds.

@onur-ozkan
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

☔ The latest upstream changes (presumably #119899) made this pull request unmergeable. Please resolve the merge conflicts.

@Zalathar
Copy link
Contributor Author

Declaring bankruptcy on all my stale PRs.

@Zalathar Zalathar closed this Jul 16, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 16, 2025
@Zalathar Zalathar deleted the download-rustc-tools branch July 16, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onur-ozkan onur-ozkan

Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Zalathar @rustbot @rust-log-analyzer @jieyouxu @onur-ozkan @bors @albertlarsan68